Re: Re: [VOTE][RFC] ZPP Failure on Overflow

From: Date: Mon, 08 Dec 2014 11:15:06 +0000
Subject: Re: Re: [VOTE][RFC] ZPP Failure on Overflow
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-79470@lists.php.net to get a copy of this message
> On 8 Dec 2014, at 08:22, Xinchen Hui <laruence@php.net> wrote: > the current warning message is :" expects parameter 1 to be long, > double given in %s on line %d" > > but maybe it should be something like: "expects parameter 1 to be > long, double(which is beyond long range) given in %s on line %d"? > > since it's not the fault of double self, right? Hi Xinchen, I had thought of doing that, although for all other failures we also don't give special error messages. I don't have the time to go through and update every single test again, though. I initially did have an error message that showed the range that the float needs to have, but this was a problem because it means the error message might vary by platform (pain to test) -- Andrea Faulds http://ajf.me/

« previous php.internals (#79470) next »