Re: [PATCH] Consistent type names in error messages
| From: | Andrea Faulds | Date: | Sun, 14 Dec 2014 20:01:44 +0000 |
| Subject: | Re: [PATCH] Consistent type names in error messages | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79645@lists.php.net to get a copy of this message | ||
> On 14 Dec 2014, at 19:59, Kalle Sommer Nielsen <kalle@php.net> wrote:
>
> 2014-12-14 19:44 GMT+01:00 Andrea Faulds <ajf@ajf.me>:
>> Hi Kalle,
>
> Hi Andrea
>> Also, a sidenote: In case someone goes and checks the manual and tells me that is_long() is
>> already an alias of is_int() and not the other way around, the manual lies. In fact, is_int() is
>> currently an alias of is_long() in master.
>>
>
> Simple fix: http://pastie.org/9780416
>
> Alternatively I can update the manual to be accurate, but I believe
> that is_long() should be an alias of is_int() too, so I'll rather
> change the C source which it has no impact on userland anyway.
It wouldn’t break anything, I say make a pull request.
--
Andrea Faulds
http://ajf.me/