Re: [PATCH] Consistent type names in error messages
| From: | Andrea Faulds | Date: | Sat, 20 Dec 2014 15:50:58 +0000 |
| Subject: | Re: [PATCH] Consistent type names in error messages | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79822@lists.php.net to get a copy of this message | ||
> On 14 Dec 2014, at 18:35, Andrea Faulds <ajf@ajf.me> wrote:
>
> I’ve made a patch which makes zend_parse_parameters and userland type hints consistently show
> “integer” and “float” rather than “long” and “double”:
> https://github.com/php/php-src/pull/955
>
> I also wrote a GNU sed script which I used to update the tests:
> https://gist.github.com/TazeTSchnitzel/c0d780466def9f226318
Hi,
Is anyone here opposed to this, or should I just merge it? I don’t think it really needs an RFC.
It doesn’t break BC.
Thanks.
--
Andrea Faulds
http://ajf.me/