Re: Re: [RFC] IntlChar class and intl_char_*() functions

Hi! > Full implementation available now at > https://github.com/sgolemon/php-src/compare/intl.uchar > RFC updated to remove the functional API and clarify some things based > on what I learned while implementing. Thanks for your work! I think it may be good to make it a pull, since it'd be easier to comment on that (and also Travis can say its word of course :) > Pay special attention to the #notes section regarding $limit which I > think is a somewhat non-PHP API. It says "some methods" but I found just one which is user-callable - enumCharNames - and one that consumes callback with the same setup - enumCharTypes - in the latter case I don't think it makes sense to change anything since it's a callback for ICU. So, if I didn't miss anything, it's one function and at that one that has matching callback in ICU API. So I think it's best to leave it as is, especially that PHP doesn't have the concept of ranges as such... -- Stas Malyshev smalyshev@gmail.com