Re: Re: [RFC] IntlChar class and intl_char_*() functions

From: Date: Tue, 16 Dec 2014 18:21:40 +0000
Subject: Re: Re: [RFC] IntlChar class and intl_char_*() functions
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-79736@lists.php.net to get a copy of this message
On Tue, Dec 16, 2014 at 12:49 AM, Stanislav Malyshev <smalyshev@gmail.com> wrote: > Thanks for your work! I think it may be good to make it a pull, since > it'd be easier to comment on that (and also Travis can say its word of > course :) > Can do! https://github.com/php/php-src/pull/961 > It says "some methods" but I found just one which is user-callable - > enumCharNames - and one that consumes callback with the same setup - > enumCharTypes - in the latter case I don't think it makes sense to > change anything since it's a callback for ICU. So, if I didn't miss > anything, it's one function and at that one that has matching callback > in ICU API. So I think it's best to leave it as is, especially that PHP > doesn't have the concept of ranges as such... > You've read it right and I agree with you. The less magic the better. I just wanted to call it out since it lacks some intuitiveness. -Sara

« previous php.internals (#79736) next »