Re: ZEND_ENGINE_2 define

Hey Sara, > On 2 Jan 2015, at 05:24, Sara Golemon <pollita@php.net> wrote: > > I realize that ZE3 is not ZE2, but I always saw the ZEND_ENGINE_2 > define as more of a "At least ZE2" so that code of the form: > > #ifdef ZEND_ENGINE_2 > newAPI(); > #else /* ZE1 */ > oldAPI(); > #endif > > Would continue making sense (modulo newNewAPI() in ZE3, of course). > > Was the ZEND_ENGINE_2 define removed on purpose? Or as an accidental > side-effect of a mass update to "We're ZE3 now!" It was deliberate, I did it. The reason for getting rid of it was because it makes checking ZE2 simpler, actually. I didn't want to have to do #if defined(ZEND_ENGINE_2) && !defined(ZEND_ENGINE_3). Thanks. -- Andrea Faulds http://ajf.me/