Re: ZEND_ENGINE_2 define
| From: | Sara Golemon | Date: | Sat, 03 Jan 2015 06:44:43 +0000 |
| Subject: | Re: ZEND_ENGINE_2 define | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-80118@lists.php.net to get a copy of this message | ||
On Fri, Jan 2, 2015 at 2:30 PM, Kalle Sommer Nielsen <kalle@php.net> wrote:
> 2015-01-02 20:41 GMT+01:00 Sara Golemon <php@golemon.com>:
>> So instead you have to do:
>> #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3)
>>
>
> #ifdef ZEND_ENGINE_3
> # define ZEND_ENGINE_2
> #endif
>
Yeah, obviously I can do that. I'm not actually an idiot, I just
disagree on which of two arbitrary choices seems more obvious.
And since we're pasting unnecessary pieces of obvious code, we could
as easily do:
#ifdef ZEND_ENGINE_3
# undef ZEND_ENGINE_2
#endif
Which leaves the decision to make the macros exclusive of each other
an arbitrary one. Just as making them inclusive would have been
equally arbitrary. But thank you for the unnecessary piece of obvious
code.
-Sara