Re: Faster zend sorting implementation

Hi all, On Wed, Jan 7, 2015 at 12:14 AM, David Zuelke <dz@heroku.com> wrote: > > I am not sure about that. Introducing a not easy to catch BC break for > > 0.1% gain on function (or even for the whole app) is not very > > appealing. > > > > However, there is nothing in the documentation actually describing how > > it works and there are clear warnings about the unpredictable results. > > That means we won't actually break it,per definition. I only wonder if > > it is worth the effort for such little gain (yes, the ocean is made of > > drops ;). > > The clear benefit I see is that it turns it into a stable sort, although > we could of course always break that again in the future unless we > explicitly specify/guarantee it to be stable from now on (without any other > guarantees about the algorithm). Stable sort is more intuitive than unstable sort. Since stable sort is a little faster than current, the only issue would be "whether we will make it a feature or not". This might be a good theme for RFC in the future. (Just merge the patch and decide later.) Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net