Re: Re: Faster zend sorting implementation

On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote: > Hi! > >> I made a PR here: >> https://github.com/php/php-src/pull/999 for reviewing >> >> in benchmark this can brings more than 30% performance gain in >> array_sort etc functions. >> >> tests fails are related to non-stable vs stable sorting difference. >> >> anyway, I feel it's better to ask you to do a final review, what >> do you think? >> >> is there any objections to merge this? > > I think the sort order of equal elements was never defined, so changing > it would not be a big issue. The tests, of course, need to be fixed and > note in UPGRADING should be provided, but otherwise it's fine. Same here, all good as long as a notice is present and tests are updated.