Re: [RFC] Remove PHP 4 Constructors

From: Date: Sat, 17 Jan 2015 09:51:42 +0000
Subject: Re: [RFC] Remove PHP 4 Constructors
References: 1 2  Groups: php.internals 
Request: Send a blank email to internals+get-80685@lists.php.net to get a copy of this message
On 17/01/15 05:54, Pierre Joye wrote: >> > Andrea Faulds has kindly written a utility that identifies when a PHP >> > 4 constructor is defined[2]. It does not automatically change the code >> > for liability reasons. The utility PHPMD[3] can also detect this but >> > has a false positive when __construct is also defined. > Not much to say about it as it is a taste/yes/no thing. > > Let wait the required period and move to vote, I do not see much needs > to argue in a circular way forever :) Switching code to __construct is on my 5.2 to 5.4 upgrade crib sheet. I thought because e_strict moans about it? But on a quick scan I can't find a reference other than NOT flagging a warning when different parameters are used. Obviously this modernise is useful anyway, but where does it fit in the error handling currently? -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk

« previous php.internals (#80685) next »