Re: [PATCH] Fix potential int overflow in date extension.
| From: | Joshua Rogers | Date: | Mon, 19 Jan 2015 19:23:04 +0000 |
| Subject: | Re: [PATCH] Fix potential int overflow in date extension. | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-80846@lists.php.net to get a copy of this message | ||
On 20/01/15 06:15, Joshua Rogers wrote:
> --
> ext/date/lib/tm2unixtime.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Somebody please take a look at /ext/date/lib/parse_tz.c too:
438timelib_sll timelib_get_current_offset(timelib_time *t)
[..]
446 return (t->z + t->dst) * -60;
Should that be cast timelib_sll too?
I think perhaps the function should be an int, seeing as it looks like
the result should be negative. Somebody please check.
--
-- Joshua Rogers <https://internot.info/>
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc