Re: [PATCH] Fix potential int overflow in date extension.

Hi all, On Tue, Jan 20, 2015 at 4:23 AM, Joshua Rogers <honey@internot.info> wrote: > On 20/01/15 06:15, Joshua Rogers wrote: > > -- > > ext/date/lib/tm2unixtime.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > Somebody please take a look at /ext/date/lib/parse_tz.c too: > > 438timelib_sll timelib_get_current_offset(timelib_time *t) > [..] > 446 return (t->z + t->dst) * -60; > Should that be cast timelib_sll too? > > I think perhaps the function should be an int, seeing as it looks like > the result should be negative. Somebody please check. I'm not familiar with timelib. Anyway, if you could send PR, it would be nicer. Or at least a bug report. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net