Re: com php-src: Fixes to unified stdint usage: ext/date/lib/timelib_structs.h main/php_stdint.h

On Wed, Jan 21, 2015 at 9:54 AM, Anatol Belski <ab@php.net> wrote: > Hi Derick, > > On Tue, January 20, 2015 22:08, Derick Rethans wrote: >> Hi Anatol! >> >> >> (Yes, I realise this is from more than a year ago) >> >> >> This commit makes timelib include a PHP specific file. timelib also >> lives as an external library (https://github.com/derickr/timelib) and is >> used by other projects. Because it's sort of an external library, we can't >> include PHP's headers (php_stdint.h) in this case. >> >> How do you suppose we can fix this? Right now, I can't easily test >> changes to the date/time parser (as they require *just* the lib). >> >> cheers, Derick >> >> >> >> On Mon, 12 Aug 2013, Anatol Belski wrote: >> >> >>> Commit: acea91b18c26149f753a037b96bed9e2b61bfdd1 >>> Author: Anatol Belski <ab@php.net> Mon, 12 Aug 2013 13:39:17 >>> +0200 >>> Parents: 52dac3e8cda94c8f38287ec3c437d9450b31b527 >>> Branches: master >>> >>> >>> Link: >>> >>> http://git.php.net/?p=php-src.git;a=commitdiff;h=acea91b18c26149f753a03 >>> 7b96bed9e2b61bfdd1 >>> > > I've just fixed here > > http://git.php.net/?p=php-src.git;a=commitdiff;h=2f8d40ca79224900af6e93c8763412204bbfb8fd > , please check. This is a horrible fix :) Please include the php_stdint.h when built with PHP and keep the rest as it was if built outside php. But duplicate stdint is a no-go and a maintenance pain. Cheers, -- Pierre @pierrejoye | http://www.libgd.org