Re: Re: com php-src: Fixes to unified stdint usage: ext/date/lib/timelib_structs.h main/php_stdint.h
| From: | Anatol Belski | Date: | Wed, 21 Jan 2015 10:57:37 +0000 |
| Subject: | Re: Re: com php-src: Fixes to unified stdint usage: ext/date/lib/timelib_structs.h main/php_stdint.h | ||
| References: | 1 2 3 4 5 6 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-80928@lists.php.net to get a copy of this message | ||
On Wed, January 21, 2015 11:17, Derick Rethans wrote:
> On Wed, 21 Jan 2015, Anatol Belski wrote:
>
>
>> I'll backport it to 5.6. Also would add the Pierre's suggestion so
>> those defines are only used when it's not inside PHP, as under
>> circumstances it could lead to different defines or conflicts. This is
>> easy done through the timelib_config.h include as that file is already
>> being generated by configure.
>
> timelib really should not have references to PHP - it should never have
> been in timelib_config.h either. Is there something else we can do here?
> At some point, I'd like to change the bundling to a GIT submodule
> perhaps.
>
> cheers, Derick
>
>
i'd suggest to wrap it like
#ifdef HAVE_TIMELIB_CONFIG_H
# include "timelib_config.h"
#endif
It allows PHP or anything external to override the configs.
Regards
anatol