Proposal: Introduce a new macro:php_error_docref_ex()

From: Date: Wed, 11 Feb 2015 08:07:38 +0000
Subject: Proposal: Introduce a new macro:php_error_docref_ex()
Groups: php.internals 
Request: Send a blank email to internals+get-82448@lists.php.net to get a copy of this message
Hi all, There are a lot of code use php_error_docref() macro, the first parameter mostly is NULL, before PHP7, it looks like: *php_error_docref(NULL TSRML, E_WARNING, "recursion detected");* in PHP7 *php_error_docref(NULL, E_WARNING, "recursion detected");* looks better, but the first parameter look dumb. I did a simple statics, there are: Null docref: 2530 Not Null docref: 51 I searched on Github, it seems that almost all of the extension use NULL docref. So I propose add a new macro, like: php_error_error_docref_ex(E_WARNING, "xxx"). this could make code looks better and the extension maintainer's easier. Another option would be just update the php_error_docref() macro to remove the docref parameter, default to NULL but not add a new macro. What do you think about it? [1] https://github.com/php/php-src/pull/1075 -- Reeze Xia http://reeze.cn

« previous php.internals (#82448) next »