Re: Re: Proposal: Introduce a new macro:php_error_docref_ex()

Why not leave it as it is? I mean, really, those five strokes? Wherever it's going, I'm -1 on changing the meaning of the existing macro. On 11 Feb 2015 16:01, "reeze" <reeze@php.net> wrote: > Hi, > > On 11 February 2015 at 19:15, Dmitry Stogov <dmitry@zend.com> wrote: > > > Hi, > > > > I don't think it'll improve something, and may complicate merging from > > PHP5 (this is not a big issue, because merging is already not simple). > > > > > Yes it just makes code looks a little better and cleaner. > > I didn't realized the merging problem. that might affect diffs which > changes php_error_docref() > > > > In any case, the names should be swapped, to be used as: > > > > php_error_docref(E_WARNING, "recursion detected"); > > > > or > > > > php_error_docref_ex(NULL, E_WARNING, "recursion detected"); > > > > Yes I prefer this too. > > But considering the merging problem, I think I should hold this idea of > update all of those calls. > > We may provider a simple version with default null docref for external > extesions, but I didn't have proper name for that. > > > > > > > > also macros with __VA_ARGS__ may be not portable, s it should be > > implemented differently. > > > > Yes I should use ##__VA_ARGS__ instead. > > > > Thanks. Dmitry. > > > > > > > > On Wed, Feb 11, 2015 at 11:41 AM, Xinchen Hui <laruence@php.net> wrote: > > > >> Hey: > >> > >> On Wed, Feb 11, 2015 at 4:35 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> > wrote: > >> > Hi all, > >> > > >> > On Wed, Feb 11, 2015 at 5:21 PM, reeze <reeze@php.net> wrote: > >> >> > >> >> I think it is a cleanup, it works but there are too many duplication. > >> it > >> >> is the time to make the code clean and easier to understand. > >> > > >> > > >> > I've never used other than NULL also. > >> > Everyone is going to remove TSRM macros, it's right time to clean up. > >> fine, if you want to change.. > >> > >> please, _ex means extending, > >> > >> so the name should not be php_error_docref_ex... > >> > >> thanks > >> > > >> > Regards, > >> > > >> > -- > >> > Yasuo Ohgaki > >> > yohgaki@ohgaki.net > >> > >> > >> > >> -- > >> Xinchen Hui > >> @Laruence > >> http://www.laruence.com/ > >> > > > > > > > -- > Reeze Xia > http://reeze.cn >