Re: [RFC][VOTE] Improve array to string conversion

Le lun. 2 mars 2015 à 13:39, Patrick ALLAERT <patrickallaert@php.net> a écrit : > Le mer. 25 févr. 2015 à 12:16, Xinchen Hui <laruence@php.net> a écrit : > > Hey: >> >> On Tue, Feb 24, 2015 at 12:06 AM, François Laupretre <francois@php.net> >> wrote: >> > Hi, >> > >> > Starting the vote for >> > https://wiki.php.net/rfc/array-to-string. >> > >> > Please note that, while the initial RFC proposed both options of either >> > fully supporting the feature, or disabling it, the voting choices are >> now : >> > >> > - either definitely disabling array to string conversion, >> > - or keep current behavior as-is. >> > >> > Vote ends March 6, 00:00 (UTC). >> replace E_NOTICE with E_RECOVERABLE_ERROR?? >> >> it's a huge BC break..... >> >> I vote -1 on this. >> >> thanks >> > >> > Regards >> > >> > François >> > >> > >> > -- >> > PHP Internals - PHP Runtime Development Mailing List >> > To unsubscribe, visit: http://www.php.net/unsub.php >> >> >> >> -- >> Xinchen Hui >> @Laruence >> http://www.laruence.com/ >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php > > > Hello, > > I'm explaining here the reasons of my "-1" vote. > > 1) You suggest (in your PR) changing the conversion > in _convert_to_string() but not in zend_make_printable_zval(). That makes > it completely inconsistent. > Forgot to mention that if you correct this important inconsistency you won't have 32 broken tests but hundreds. Thanks, Patrick