Re: [RFC][VOTING] Context Sensitive Lexer

From:	Matteo Beccati	Date:	Mon, 09 Mar 2015 08:44:01 +0000
Subject:	Re: [RFC][VOTING] Context Sensitive Lexer
References:	1 2 3 4	Groups:	php.internals
Request:	Send a blank email to internals+get-84456@lists.php.net to get a copy of this message

Hi Marcio,

Just passing by to announce I already have a working version of the new patch: https://github.com/php/php-src/pull/1158 The patch is 100% compatible with the proposed one with the advantages:
    - Has no regression or forward compatibility risks and is highly
    predictable
    - Has an very small footprint compared to the previous attempt involving
    a pure lexical approach
    - Is highly configurable, to make a word semi-reserved you only have to
    edit a single inclusive list in a parser rule.
    - Requires a single compile time check
More than ever, I'd like to advice voters to vote for the feature as the new implementation is already on it's way. There still some work to be done, please refer to the task list on the pull request to see what still needs to be done.

I like the approach. I'm no lexer expert but the new PR seems much nicer. Moreover, I like the feature itself but previously voted no on the implementation. I've therefore switched my vote to a "yes". -- Matteo Beccati Development & Consulting - http://www.beccati.com/