Re: [RFC][VOTING] Context Sensitive Lexer
| From: | Nikita Popov | Date: | Wed, 11 Mar 2015 14:49:38 +0000 |
| Subject: | Re: [RFC][VOTING] Context Sensitive Lexer | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-84547@lists.php.net to get a copy of this message | ||
On Mon, Mar 9, 2015 at 6:47 AM, Marcio Almada <marcio.web2@gmail.com> wrote:
> Hi,
>
> Just passing by to announce I already have a working version of the new
> patch: https://github.com/php/php-src/pull/1158
>
> The patch is 100% compatible with the proposed one with the advantages:
>
> - Has no regression or forward compatibility risks and is highly
> predictable
> - Has an very small footprint compared to the previous attempt involving
> a pure lexical approach
> - Is highly configurable, to make a word semi-reserved you only have to
> edit a single inclusive list in a parser rule.
> - Requires a single compile time check
>
> More than ever, I'd like to advice voters to vote for the feature as the
> new implementation is already on it's way. There still some work to be
> done, please refer to the task list on the pull request to see what still
> needs to be done.
>
> It would be nice to have the new patch reviewed too.
>
The new implementation does indeed look much nicer :) The only open
question left is how you want to deal with ext/tokenizer support. Can you
clarify your plan regarding that?
Also, is this vote about the new implementation now?
Nikita