Re: [VOTE] Exceptions in the engine

Why not wait with the merge until a consensus emerges regarding Throwable? > On 09.03.2015, at 05:26, Nikita Popov <nikita.ppv@gmail.com> wrote: > > On Mon, Feb 23, 2015 at 7:15 PM, Nikita Popov <nikita.ppv@gmail.com> wrote: > >> Hi internals! >> >> Voting on the engine exceptions RFC, which proposes to convert existing >> fatal and recoverable fatal errors into exceptions, has opened: >> >> https://wiki.php.net/rfc/engine_exceptions_for_php7#vote >> >> The primary vote requires a 2/3 majority, as this is a language change. >> >> A second vote will decide whether to use a BaseException based inheritance >> hierarchy. This vote uses a simple majority. >> >> Voting is open until 2015-03-08. >> > > This RFC has been accepted with 60 votes in favor and 2 against. The > BaseException hierarchy has been accepted with 39 in favor and 19 against. > > During voting some concerns about the naming of the BaseException class > have been raised. This detail can be sorted out in a follow-up discussion - > changing this (assuming only the name is changed) is simple and only a > couple of tests need to be adjusted. > > Dmitry, do you want to merge your current patch? > > Nikita