Re: What's our official stance on small self-contained additions in a micro version

On 30/03/15 12:04, Ferenc Kovacs wrote: > Hi, > > I know that our official release process allows that, but there are some > reasonable arguments against doing that and this topic was brought up > multiple times related to specific fixes. > I have two open PRs like that: > https://github.com/php/php-src/pull/1204 > https://github.com/php/php-src/pull/969 > and of course there are a bunch of similar ones from other people, and > there are cases when somebody simply pushes a change like that, other times > somebody points out that it should require an RFC( > https://wiki.php.net/rfc/json_preserve_fractional_part for > example), but > most of the times we simply don't know what to do, and eventually we just > let the PR/patch to rot and die. > I would like to know if we can come up with a rule which can have consensus > behind it, and maybe formalize it as an extension to our current > releaseprocess rfc. > > What do you think? > How about: It's okay, if it does not need version_compare(PHP_VERSION) but can be tested by e.g. defined("SOME_CONSTANT") or function_exists("fn")? -- Regards, Mike