Re: Optimizing php_html_entities()
| From: | Yasuo Ohgaki | Date: | Tue, 23 Jun 2015 21:41:42 +0000 |
| Subject: | Re: Optimizing php_html_entities() | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-86817@lists.php.net to get a copy of this message | ||
Hi Anthony,
On Wed, Jun 24, 2015 at 12:21 AM, Anthony Ferrara <ircmaxell@gmail.com>
wrote:
> In addition, this breaks the contract, specifically when using scalar
> types. Because you're no longer going to error when the contract is
> broken (considering htmlspecialchars is documented as string:string).
>
What do you mean by "break the contract".
"string" parameter is not a requirement/contract.
htmlspecialchars/htmlentities
just converts param to string. The patch does not change anything as you
can
see it from the phpt results.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net