Re: Optimizing php_html_entities()

Hey: On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > Hi Xinchen, > > On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui <laruence@php.net> wrote: >> >> But passing an non-string to htmlspecialchars are not common used cases.. >> >> "optimize" not common used cases... will bring nothing to us.. > > > The reason why I looked into this in the first place is one of my friend > complained about slow htmlspecialchars for relatively large table data. > > He said more than half of execution time is took by htmlspecialchars > because > > - it escapes numeric values as string > - it does not accept array value for to be escaped values > > 1st is covered by this patch. > 2nd issue is covered by this FR. > https://bugs.php.net/bug.php?id=69908 > > So it brings something for us :) Then what about strlen(number)? are you also going to change its ZPP to accept zval instead of string? thanks > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > -- Xinchen Hui @Laruence http://www.laruence.com/