Re: Change IntlChar::getNumericValue() to return something less horrible when the char is not numeric?

I've asked Sara to add the NO_NUMERIC_VALUE constant to IntlChar because it is missing, but she suggested the method could return NULL instead. Any of the two options is fine for me... 2015-07-08 21:45 GMT+02:00 Stanislav Malyshev <smalyshev@gmail.com>: > Hi! > > > ICU documentation: > > > > http://icu-project.org/apiref/icu4c/uchar_8h.html#a36982efc84143b9bb5a11bf54b86af48 > > > > Currently the PHP function returns the U_NO_NUMERIC_VALUE constant, which > > is set to the very weird "float(-123456789)"; basically it's a value that > > it's certain it doesn't have an Unicode numeric character equivalent > > counterpart. > > > > I would change the function to return NULL instead; what do you think? > > While the exact value of U_NO_NUMERIC_VALUE looks weird, nobody is going > to use it directly, you'd be using U_NO_NUMERIC_VALUE. Comparing to it > doesn't look wrong. So changing that to null doesn't seem to improve > much, just introduce incompatibility with ICU. > > -- > Stas Malyshev > smalyshev@gmail.com >