Re: Change IntlChar::getNumericValue() to return something less horrible when the char is not numeric?

Hi On Wed, Jul 8, 2015 at 9:45 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote: >> I would change the function to return NULL instead; what do you think? > > While the exact value of U_NO_NUMERIC_VALUE looks weird, nobody is going > to use it directly, you'd be using U_NO_NUMERIC_VALUE. Comparing to it > doesn't look wrong. So changing that to null doesn't seem to improve > much, just introduce incompatibility with ICU. personally, I think null (or even false) is better because it's of a different type (and falsy) and thus more likely to get noticed that something is wrong. In PHP, you're used to checking for null or false. Having to deal with values that look like they are within valid ranges and which also validate to something true-ish is needlessly difficult and unexpected. The unicode standard apparently wants to use NaN, so ICU is already deviating from the standard. Philip