Re: RFE to allow dirname($foo, 2)
| From: | Remi Collet | Date: | Fri, 24 Jul 2015 08:39:47 +0000 |
| Subject: | Re: RFE to allow dirname($foo, 2) | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-87265@lists.php.net to get a copy of this message | ||
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Le 24/07/2015 02:11, Hannes Magnusson a écrit :
> On Wed, Jul 22, 2015 at 4:55 AM, Remi Collet
> <remi@fedoraproject.org> wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>>
>> See https://bugs.php.net/bug.php?id=70112
>>
>>
>> As this a very small self-contained change, I don't think it
>> needs a RFE.
>>
>> Feedback welcome
>
>
>
>
> Shouldn't you check if you are at the root (or cwd)? currently
> dirname("/foo/bar", PHP_INT_MAX); "hangs"
Good catch.
Should be ok now.
Remi.
>
>
> -Hannes
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlWx+dMACgkQYUppBSnxahjuPACgxZ+yLXbLzQXZKmJhWAbH0OD9
jqAAnjImkjL6j+p4dsRC0IC8N6fRKFXc
=4YM4
-----END PGP SIGNATURE-----