RE: [PHP-DEV] Windows OpCache bug fix
| From: | Anatol Belski | Date: | Wed, 23 Sep 2015 08:27:44 +0000 |
| Subject: | RE: [PHP-DEV] Windows OpCache bug fix | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-88429@lists.php.net to get a copy of this message | ||
Hi Matt,
> -----Original Message-----
> From: Matt Ficken [mailto:themattficken@gmail.com]
> Sent: Wednesday, September 23, 2015 9:10 AM
> To: PHP Internals <internals@lists.php.net>
> Cc: dmitry@php.net; laruence@php.net
> Subject: [PHP-DEV] Windows OpCache bug fix
>
> I want to increase visibility for my PR 1531,
> https://github.com/php/php-
> src/pull/1531, my patch for fixing an intermittent OpCache issue on Windows.
>
> Details, etc... are on the PR.
>
thanks for the patch. It's great to fix that "base address" issue in PHP-7.0 at
least. It would probably make sense to backport it to 5.6 later.
One minor comment though - you shouldn't use C++ comments there according to the coding styles.
Regards
Anatol