Re: Windows OpCache bug fix

Hi Matt, It looks like with your patch, the same file may be mapped to different virtual addresses of different processes and this won't work. I think usage of vista_mapping_base_set[] in your patch is wrong. Do I understand properly, that zend_shared_alloc_unlock/lock_win32() around Sleep() is the main part of the patch? Please, next time, try to make PR diffs as small as possible (without messing real fix with formatting and rearranging changes). Thanks. Dmitry. On Wed, Sep 23, 2015 at 10:10 AM, Matt Ficken <themattficken@gmail.com> wrote: > I want to increase visibility for my PR 1531, > https://github.com/php/php-src/pull/1531, my patch for fixing > an > intermittent OpCache issue on Windows. > > Details, etc... are on the PR. > > Regards > -M >