zend_parse_parameters changes not fully documented in phpng-upgrading, PR to fix existing tools
| From: | Sean DuBois | Date: | Wed, 23 Sep 2015 20:39:39 +0000 |
| Subject: | zend_parse_parameters changes not fully documented in phpng-upgrading, PR to fix existing tools | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-88454@lists.php.net to get a copy of this message | ||
Hey list,
'l' had a change 'long' -> 'zend_long' and 's' had a
change 'int' -> 'size_t'.
These two changes are really hard to catch when porting an extension,
nothing complains at compile time, you don't get segfaults when calling
zend_parse* but usually later and it is platform dependent
(Windows for me when porting phpredis) I am lucky that I had a developer
(Jan-E) help me with this, or I would have pushed the extension out the door broken
for many people.
A.) Can someone merge https://github.com/php/php-src/pull/1521 this is
currently
the only solution I know of to catch these things in an automated way
B.) Can someone give me access to https://wiki.php.net/phpng-upgrading so I can
document
this
C.) Has there ever been a conversation about improving extension building so that authors
don't have to go out of their way to catch these things? I would really like to see phpize
kick out a Makefile that in the process of building/testing would raise alerts about this.