Re: zend_parse_parameters changes not fully documented in phpng-upgrading, PR to fix existing tools

On Wed, 23 Sep 2015, Sean DuBois wrote: > Hey list, > > 'l' had a change 'long' -> 'zend_long' and 's' had a > change 'int' -> > 'size_t'. > > These two changes are really hard to catch when porting an extension, > nothing complains at compile time, you don't get segfaults when > calling zend_parse* but usually later and it is platform dependent > (Windows for me when porting phpredis) I am lucky that I had a > developer (Jan-E) help me with this, or I would have pushed the > extension out the door broken for many people. > > A.) Can someone merge https://github.com/php/php-src/pull/1521 > this is > currently the only solution I know of to catch these things in an > automated way I didn't know this script existed! I've added a few comments. Once resolved, I'll merge it. > B.) Can someone give me access to > https://wiki.php.net/phpng-upgrading > so I can document this What's your wiki username? > C.) Has there ever been a conversation about improving extension > building so that authors don't have to go out of their way to catch > these things? I would really like to see phpize kick out a Makefile > that in the process of building/testing would raise alerts about this. Conversations yes, solutions, no. I'd be awesome to have this though. cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug Posted with an email client that doesn't mangle email: alpine