Re: couple of PRs for master
| From: | Anthony Ferrara | Date: | Wed, 07 Oct 2015 15:27:59 +0000 |
| Subject: | Re: couple of PRs for master | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-88716@lists.php.net to get a copy of this message | ||
Fernec,
On Wed, Oct 7, 2015 at 10:13 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
> Hi,
>
> I have a couple of pending PRs which are all small features with
> outstanding bugreports/feature requests and I wasn't sure that they would
> need an RFC or not, I would like to get some feedback about that:
> https://github.com/php/php-src/pull/1214
> https://github.com/php/php-src/pull/1204
> https://github.com/php/php-src/pull/969
>
> ps: they are all targeting master and I can merge them myself I just wanted
> to make sure if they need further discussion or RFC.
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
IMHO they are all simple and self-contained enough not to really need
an RFC. We could bikeshed the function names, etc, but besides that I
don't see much that would warrant an RFC here (based on my
understanding/view on the process).
Thanks
Anthony