RE: [PHP-DEV] couple of PRs for master
| From: | Anatol Belski | Date: | Wed, 07 Oct 2015 17:07:57 +0000 |
| Subject: | RE: [PHP-DEV] couple of PRs for master | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-88717@lists.php.net to get a copy of this message | ||
Hi Ferenc,
> -----Original Message-----
> From: Ferenc Kovacs [mailto:tyra3l@gmail.com]
> Sent: Wednesday, October 7, 2015 4:14 PM
> To: PHP Internals <internals@lists.php.net>
> Subject: [PHP-DEV] couple of PRs for master
>
> Hi,
>
> I have a couple of pending PRs which are all small features with outstanding
> bugreports/feature requests and I wasn't sure that they would need an RFC or
> not, I would like to get some feedback about that:
> https://github.com/php/php-src/pull/1214
> https://github.com/php/php-src/pull/1204
> https://github.com/php/php-src/pull/969
>
> ps: they are all targeting master and I can merge them myself I just wanted to
> make sure if they need further discussion or RFC.
>
IMO it is fine to take the PRs as is into master. Since those are FRs and small, that's fine.
Regards
Anatol