Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()
| From: | Nikita Popov | Date: | Mon, 12 Oct 2015 18:56:55 +0000 |
| Subject: | Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure() | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-88752@lists.php.net to get a copy of this message | ||
On Mon, Oct 12, 2015 at 8:24 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi Nikita,
>
> I think the effect of the remaining patch is negligible.
> It disables things, that shouldn't work by design, didn't work in fact and
> leaded to crashes.
> It might work only in some cases and only because of luck.
>
> So, I think it's better to commit this before next RC.
> Anatol is going to start rolling it on Tuesday.
>
Done.
> It would be great, if we stop any commits into PHP-7.0 except for
critical fixes now
Maybe keep PHP-7.0 open (or as open as release branches usually are), but
from now on only cherry-pick critical fixes into PHP-7.0.0 (instead of
merging everything)?
Nikita