Re: Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()
| From: | Nikita Popov | Date: | Mon, 12 Oct 2015 20:32:36 +0000 |
| Subject: | Re: Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure() | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-88755@lists.php.net to get a copy of this message | ||
On Mon, Oct 12, 2015 at 10:22 PM, Anatol Belski <anatol.php@belski.net>
wrote:
> Hi,
>
> > -----Original Message-----
> > From: Nikita Popov [mailto:nikita.ppv@gmail.com]
> > Sent: Monday, October 12, 2015 8:57 PM
> > To: Dmitry Stogov <dmitry@zend.com>
> > Cc: PHP internals <internals@lists.php.net>; Andrea Faulds <ajf@ajf.me>;
> Stas
> > Malyshev <smalyshev@sugarcrm.com>; Bob Weinand <bwoebi@php.net>;
> > Anatol Belski <anatol.php@belski.net>
> > Subject: [PHP-DEV] Re: Forbid rebinding scope of closures created by
> > ReflectionFunctionAbstract::getClosure()
> >
> > > It would be great, if we stop any commits into PHP-7.0 except for
> > critical fixes now
> >
> > Maybe keep PHP-7.0 open (or as open as release branches usually are),
> but from
> > now on only cherry-pick critical fixes into PHP-7.0.0 (instead of merging
> > everything)?
> >
> I commit myself to Dmitry's words. What matters today and especially after
> RC5 is the stability. Today we should invest into testing and bug fixes
> more than into improvements (aka fixes to something that is not broken). It
> really matters for the quality of the final. That's the message to convey
> probably.
>
To rephrase my question: Should we treat PHP-7.0 the same way we treat
PHP-5.6 and other release branches (i.e. all kinds of bug fixes are okay,
even if it's just improving a test or fixing some inconsequential
behavior), or do you want to limit the PHP-7.0 branch to actually critical
fixes now? From what you say, I assume the former rather than the latter?
Nikita