Re: [RFC][VOTE] Deprecate then Remove Mcrypt Closed (23-6)

Hi, On Tue, Mar 22, 2016 at 9:23 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote: > Hi! > > > be in the spirit of what was voted on to keep it (at least as an alias > for > > random_bytes()). However, that was not covered by what everyone voted > for. > > How would you like to proceed? > > I'd say keep it - either as an alias of as a function, doesn't matter. > It looks like common sense BC measure and doesn't seem to hurt anything. > If we'll be moving whole extension out to PECL, we could keep this > particular function as an alias. > > While keeping it as an alias wouldn't be the worst thing ... I disagree, exactly because the whole extension is moved to PECL. mcrypt isn't an extension enabled by default and I'm yet to see a piece of code that doesn't do one of the following checks before calling mcrypt_create_iv(): - function_exists('mcrypt_create_iv') - extension_loaded('mcrypt') - defined('MCRYPT_DEV_URANDOM') // or another MCRYPT_* constant Unless of course it's a part of a library that explicitly depends on ext/mcrypt being enabled. So ... I don't see this alias really helping more than a handful of people. Cheers, Andrey.