Re: [RFC Discussion] Typed Properties

Hi Dmitry, The patch is pretty close to complete. When you start to dig a bit further, you'll notice that I prepared for using cached pointers to prop info, but, I'm not sure how to allocate those as the handlers are using the currently allocated slots so differently. I also patched opcache, but it's probably wrong (or not good enough, not sure what to do about type_ce). Please do start working on the patch, that would be great ... I'll leave it alone for you to do your thing :) Cheers Joe On Tue, Mar 29, 2016 at 5:12 PM, Dmitry Stogov <dmitry@zend.com> wrote: > Hi Phil, hi Joe, > > Is your patch complete? > > I took just a brief review yet, and I would like to make a deep check once > again (and may be optimization). > I saw, the patch makes some slowdown, but less than I expected. > If you are not going to modify the patch in next two days, I would start > working on it tomorrow. > > RFC itself looks fine. > > Thanks. Dmitry. > > ________________________________________ > From: Phil Sturgeon <pjsturgeon@gmail.com> > Sent: Tuesday, March 29, 2016 18:32 > To: Andrey Andreev > Cc: internals@lists.php.net > Subject: Re: [PHP-DEV] [RFC Discussion] Typed Properties > > I'd like to thank everyone for their feedback on this RFC! > > It looks like the majority of concerns were solved during the course > of this discussion, which is great news. > > The RFC has been expanded in a few areas to take care of a few other > concerns, so please go and review it and let me know if you have any > feedback. > > https://wiki.php.net/rfc/typed-properties > > Voting will start in a few days. > > Cheers, > Phil > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >