Re: [RFC][Discussion] Add session_gc()
| From: | Yasuo Ohgaki | Date: | Fri, 08 Apr 2016 05:12:43 +0000 |
| Subject: | Re: [RFC][Discussion] Add session_gc() | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-92156@lists.php.net to get a copy of this message | ||
Hi Andrey,
On Fri, Apr 8, 2016 at 12:46 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>>
>> The signature for SessionHandlerInterface::gc() accepts a TTL value as a
>> parameter; session_gc() can too:
>>
>> function session_gc($ttl = ini_get('session.gc_maxlifetime')) {}
>>
>> * Note: The current patch doesn't actually ignore gc_probability, but I
>> think that's by mistake (also relevant to my previous point). I'll comment
>> on the PR on GitHub.
>
> Good point.
> Since session module does the job if module should execute GC or not.
> It should be 1 or very short time.
PS(gc_maxlifetime) is needed, so I fixed the last commit.
Regards,
P.S. I'm having bad cold. So it may be better not to commit a while :(
--
Yasuo Ohgaki
yohgaki@ohgaki.net