Re: base64_decode is buggy, what to fix?

Completely missing padding shouldn't fail, it's often removed to save space or when base64 is converted to base64url. Joe Watkins <pthreads@pthreads.org> schrieb am Mo., 23. Mai 2016 06:59: > Morning, > > Would it be possible to open a PR that fixes the programming errors, > such as oob read, and the strange flow of the subsequent block ? > > Assuming those fixes don't effect normal usage, I see no reason why > that can't be merged immediately. > > When it comes to changing the behaviour, that needs a little more > discussion I think, and I wait to see what others think about those > changes. > > Cheers > Joe > > On Mon, May 23, 2016 at 1:52 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > > > Hi Lauri, > > > > On Sun, May 22, 2016 at 7:56 PM, Lauri Kenttä <lauri.kentta@gmail.com> > > wrote: > > > > > > Suggestions? > > > > IMHO > > > > Return FALSE for any invalid input when strict mode is on. > > Enable strict mode by default. > > Keep current behavior when strict mode is off. > > > > would be the best. > > > > Regards, > > > > -- > > Yasuo Ohgaki > > yohgaki@ohgaki.net > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > >