Re: [RFC][Vote] Typed Properties
| From: | Dmitry Stogov | Date: | Mon, 23 May 2016 08:04:03 +0000 |
| Subject: | Re: [RFC][Vote] Typed Properties | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-93433@lists.php.net to get a copy of this message | ||
The patch "corrupts" opcache shared memory.
PHP crashes with opcache.protect_memory=1.
$ USE_ZEND_ALLOC=0 valgrind sapi/cli/php -d opcache.protect_memory=1
../Zend/tests/type_declarations/typed_properties_027.php
==900== Memcheck, a memory error detector
==900== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==900== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info
==900== Command: sapi/cli/php ../Zend/tests/type_declarations/typed_properties_027.php
==900==
==900==
==900== Process terminating with default action of signal 11 (SIGSEGV)
==900== Bad permissions for mapped region at address 0xF00FFBC8
==900== at 0x86391FE: zend_verify_weak_scalar_type_hint (zend_execute.c:725)
==900== by 0x8639833: zend_verify_scalar_property_type (zend_execute.c:869)
==900== by 0x8639C2B: zend_verify_property_type (zend_execute.c:938)
==900== by 0x862E46D: zend_std_write_property (zend_object_handlers.c:753)
==900== by 0x8685102: ZEND_ASSIGN_OBJ_SPEC_CV_CONST_OP_DATA_CONST_HANDLER
(zend_vm_execute.h:42160)
==900== by 0x863F91D: execute_ex (zend_vm_execute.h:426)
==900== by 0x863F9D2: zend_execute (zend_vm_execute.h:471)
==900== by 0x85F38B4: zend_execute_scripts (zend.c:1427)
==900== by 0x85832B7: php_execute_script (main.c:2492)
==900== by 0x86AE2D8: do_cli (php_cli.c:982)
==900== by 0x86AEF42: main (php_cli.c:1352)
==900==
________________________________________
From: Joe Watkins <pthreads@pthreads.org>
Sent: Friday, May 20, 2016 9:05:34 AM
To: PHP internals; Phil Sturgeon
Subject: [PHP-DEV] [RFC][Vote] Typed Properties
Morning internals,
Since we have our answer on nullable types, typed properties can now go
to vote.
https://wiki.php.net/rfc/typed-properties#vote
Note that, support for nullability as RFC'd will be merged when the
implementation for nullable_types is merged into master.
Please participate.
Cheers
Joe