Re: [RFC][VOTE] E_WARNING on invalid container read-adccess

Hi Internals, My original time for vote ending was yesterday, however Yasuo requested I provide some benchmarking stats to see performance impact. I apologize I wasn't able to provide the information sooner, I was off getting married. I'd like to extend the vote through Sunday evening in the event anyone had reservations based on potential performance impact. The RFC is currently sitting 15-0 in favor. (added to RFC) Execution Time (DualCore 3ghz; 2g ram) * Current Master : ~0.09s (~489k operations) * Current Master w/RFC Displaying Warnings: ~33.25s * Current Master w/RFC Hiding Warnings: ~0.82s (~4.091m operations) We can see there is a significant increase in operations on huge loads. However, I wouldn't suspect 1m of these errors per request almost ever. So, yes there is; but I'd call it useful information overhead. -- Dave On Tue, Aug 23, 2016 at 12:50 PM Pascal MARTIN, AFUP < mailing@pascal-martin.fr> wrote: > Le 16/08/2016 à 17:55, David Walker a écrit : > > I'd like to go ahead and open up the RFC to voting to the scope > > that it is written. > > Hi, > > At AFUP, we would be +1 on this RFC. > > Basically: it could/will help detect problems, and the behavior change > should not cause too many bc-breaks (actually, when it does cause some, > it'll - probably - mostly be by detecting problems/bugs). > > Thanks for your work on this! > > -- > Pascal MARTIN, AFUP - French UG > http://php-internals.afup.org/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >