RE: [PHP-DEV] Dorin Marcoci Added Firebrid native type mapping for integers (smallint, integer, bigint) in PDO_Firebird driver

Anatol, As I saw in source code, this flag is handled by PDO base class (and I think it should be in base instead of stingifying it in all driver implementations). Not sure if this place do the magic, but I'll check and come back: https://github.com/php/php-src/blob/master/ext/pdo/pdo_stmt.c#L656 - Dorin Marcoci -----Original Message----- From: Anatol Belski [mailto:anatol.php@belski.net] Sent: Friday, January 6, 2017 9:13 PM To: 'Adam Baratz' <adambaratz@php.net>; 'marius adrian popa' <mapopa@gmail.com> Cc: 'PHP Developers Mailing List' <internals@lists.php.net>; 'Dorin Marcoci' <dorin.marcoci@marcodor.com> Subject: RE: [PHP-DEV] Dorin Marcoci Added Firebrid native type mapping for integers (smallint, integer, bigint) in PDO_Firebird driver Hi, > -----Original Message----- > From: Adam Baratz [mailto:adambaratz@php.net] > Sent: Friday, January 6, 2017 7:59 PM > To: marius adrian popa <mapopa@gmail.com> > Cc: PHP Developers Mailing List <internals@lists.php.net> > Subject: Re: [PHP-DEV] Dorin Marcoci Added Firebrid native type > mapping for integers (smallint, integer, bigint) in PDO_Firebird > driver > > > > > > > <https://github.com/madorin/php-src/tree/fb_native>Firebrid > > native type mapping for integers (smallint, integer, bigint) in > > PDO_Firebird driver > > > It looks like this is an "always on" feature. There's a PDO attribute, > PDO::ATTR_STRINGIFY_FETCHES, that's intended to allow toggling. Since > this is a functionality change, I'd suggest supporting it. It'll make > it easier for users to migrate if they have any baked-in assumptions around getting strings > back. > Good catch. Dorin, would you be up to implement this please? Thanks Anatol