RE: [PHP-DEV] Dorin Marcoci Added Firebrid native type mapping for integers (smallint, integer, bigint) in PDO_Firebird driver
| From: | Dorin Marcoci | Date: | Tue, 10 Jan 2017 18:25:24 +0000 |
| Subject: | RE: [PHP-DEV] Dorin Marcoci Added Firebrid native type mapping for integers (smallint, integer, bigint) in PDO_Firebird driver | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-97667@lists.php.net to get a copy of this message | ||
Hello Adam,
That's why I wrote " is not possible to be done it in a _nice_ way", where
"nice" is the key :)
Yes, currently it can be done by using ZVALs, but I find it over-layered & over-structured than
simply pass a zend_long for example in case of ints.
As I understand ZVAL purpose in PHP is a bit different. Later in fetch_value ZVAL is copied into
another, even not used further. A lot of unused operations.
About floating point numbers (msg89591.html), yes, great move. I'm with you and vote
"yes".
Maybe just name it PDO::PARAM_FLOAT instead of DOUBLE to be more in sync with PHP native types, as
"double" describe more a size than a type.
About unicode (msg88713.html) I think it’s a wrong way. It should be just strings/(var)chars as in
PHP/DBMSes.
We should instead improve/standardize getColumnMeta where we can return charset/collate, for other
types numeric precision etc...
Thank You,
-
Dorin Marcoci