Re: Change in type-hint representation
| From: | Markus Fischer | Date: | Wed, 11 Jan 2017 14:16:23 +0000 |
| Subject: | Re: Change in type-hint representation | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-97684@lists.php.net to get a copy of this message | ||
On 11.01.17 13:07, Dmitry Stogov wrote:
>
> https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1
- there's a typo "/* this is a calss name */" a few times
- a few times I see this condition: "if (info->type > 0x3ff) {"
Shouldn't we use *some* descriptive constant for this seamingly
cryptic looking 0x3ff ?
The approach looks great .. are there any benchmarks?
thanks,
- Markus