Re: pdo_sqlite fd leak
| From: | Rasmus Lerdorf | Date: | Sun, 22 Jan 2017 01:22:09 +0000 |
| Subject: | Re: pdo_sqlite fd leak | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-97919@lists.php.net to get a copy of this message | ||
On Sat, Jan 21, 2017 at 4:47 PM, Christoph M. Becker <cmbecker69@gmx.de>
wrote:
>
> Anyhow, the SQLite3 documentation states[1]:
>
> | The sqlite3_prepare_v2() and sqlite3_prepare16_v2() interfaces are
> | recommended for all new programs. The two older interfaces are
> | retained for backwards compatibility, but their use is discouraged.
>
> Isn't that reason enough to switch to sqlite3_prepare_v2() ASAP? Note
> that this is documented at least for more than nine years[2]!
>
> [1] <https://sqlite.org/c3ref/prepare.html>
> [2]
> <http://web.archive.org/web/20070701000000*/https://
> sqlite.org/c3ref/prepare.html>
Yes, but it also says that the behaviour is slightly different on an error
condition which could potentially affect peoples' code. Although it seems
like a subtle difference and only in the case of an error, so it should be
ok to change for 7.2.
-Rasmus