Re: pdo_sqlite fd leak

On Sat, Jan 21, 2017 at 5:22 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote: > On Sat, Jan 21, 2017 at 4:47 PM, Christoph M. Becker <cmbecker69@gmx.de> > wrote: >> >> Anyhow, the SQLite3 documentation states[1]: >> >> | The sqlite3_prepare_v2() and sqlite3_prepare16_v2() interfaces are >> | recommended for all new programs. The two older interfaces are >> | retained for backwards compatibility, but their use is discouraged. >> >> Isn't that reason enough to switch to sqlite3_prepare_v2() ASAP? Note >> that this is documented at least for more than nine years[2]! >> >> [1] <https://sqlite.org/c3ref/prepare.html> >> [2] >> <http://web.archive.org/web/20070701000000*/https://sqlite.4©ÐÀ™? >> x0Î%ƒ)AF >> org/c3ref/prepare.html> > > > Yes, but it also says that the behaviour is slightly different on an error > condition which could potentially affect peoples' code. Although it seems > like a subtle difference and only in the case of an error, so it should be > ok to change for 7.2. > Ok, I have switched pdo_sqlite to use sqlite3_prepare_v2() and sqlite3_close_v2() for PHP 7.2