Re: [RFC] [VOTE] Libsodium as a core extension in PHP 7.2

On Fri, Feb 3, 2017 at 9:44 PM, Scott Arciszewski <scott@paragonie.com> wrote: > I've opened the vote for the libsodium RFC. > > https://wiki.php.net/rfc/libsodium > > See https://externals.io/thread/626 for the previous discussion > topics. > > The vote closes at 21:00 UTC (4 PM Eastern Time) next Friday. > I just took a very quick look at the extension source. One question: Right now it throws recoverable fatal errors all over the place. Why doesn't it use exceptions instead? We replaced (to the most part) use of recoverable fatals with exceptions in PHP 7 and reintroducing them in this quantity would be highly dubious to me. Also a question on maintenance: If this extension is bundled, will the source compatibility with PHP 5 be removed, or do you plan on keeping a single code-base for the bundled extension and PECL, with support for PHP 5? None of the current bundled extensions do this, as it is a significant maintenance burden. Thanks, Nikita