Re: Re: TOKEN_AS_OBJECT for token_get_all()

On Fri, Mar 24, 2017 at 9:23 AM, Andrea Faulds <ajf@ajf.me> wrote: > Hi Nikita, > > Nikita Popov wrote: > >> I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which >> returns an array of PhpToken objects, rather than the mix of plain strings >> and arrays we currently have. The PhpToken class is defined as: >> >> class PhpToken { >> public $type; >> public $text; >> public $line; >> } > > > Rather than adding a flag to token_get_all() to return objects, you could > potentially instead make an equivalent static method on PhpToken > (PhpToken::getAll() perhaps). That would avoid mixing “object-oriented” and > “procedural” styles, though I don't know if it matters. It seems cleaner to > me. > > Thanks! > > -- > Andrea Faulds > https://ajf.me/ > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php I prefer a distinct function/method from token_get_all. I don't see the value in having a return value that differs so much based on a passed flag. I don't care so much about a function vs static method; I just oppose the additional parameter to token_get_all. I like the idea very much overall aside from that detail.