Re: Re: ZendEngine2 / zend_ini_parser.y zend_ini_scanner.l

> > A) Isn't it late in the RC cycle to be adding features? > > I guess not. I got OK from Andi & Zeev. > I realized after sending that it sounded a bit hostile. I apologize for that, but I was under the impression that we're into critical-only territory at this point, and this feature is hardly critical. No strong feelings one way or the other though. > > B) You're mising a ; (line 259) > > Where exactly? What file? It compiles fine for me. > Zend/zend_ini_parse.y http://cvs.php.net/co.php/ZendEngine2/zend_ini_parser.y And in fact, now that I look again, you're missing a couple of 'em. One to terminate the var_string_list: block and another to terminate the cfg_var_ref: block. Maybe your version of bison is more forgiving than mine, I'm using 1.75. Looks like it's enough to stop the Win32 snap though: http://snaps.php.net/win32/snapshot.log \cygwin\bin\bison.exe --output=Zend/zend_ini_parser.c -v -d -p ini_ Zend/zend_ini_parser.y Zend/zend_ini_parser.y:261.12: parse error, unexpected ":", expecting ";" or "|" Zend/zend_ini_parser.y:267.20-54: invalid $ value Zend/zend_ini_parser.y:268.20-54: invalid $ value NMAKE : fatal error U1077: '\cygwin\bin\bison.exe' : return code '0x1' Stop. NMAKE : fatal error U1077: '"c:\Program Files\Microsoft Visual Studio\VC98\bin\NMAKE.EXE"' : return code '0x2' Stop. My error message under Linux amounts to the same: bison -y -p ini_ -v -d /home/sarag/cvs/php5/Zend/zend_ini_parser.y -o Zend/zend_ini_parser.c /home/sarag/cvs/php5/Zend/zend_ini_parser.y:261.12: parse error, unexpected ":", expecting ";" or "|" /home/sarag/cvs/php5/Zend/zend_ini_parser.y:267.20-54: invalid $ value /home/sarag/cvs/php5/Zend/zend_ini_parser.y:268.20-54: invalid $ value make: *** [Zend/zend_ini_parser.c] Error 1 -Sara