RE: [PHP-DEV] [RFC][VOTE] Improved SSL / TLS constants
| From: | Anatol Belski | Date: | Mon, 29 May 2017 20:29:54 +0000 |
| Subject: | RE: [PHP-DEV] [RFC][VOTE] Improved SSL / TLS constants | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-99239@lists.php.net to get a copy of this message | ||
Hi Niklas,
> -----Original Message-----
> From: Niklas Keller [mailto:me@kelunik.com]
> Sent: Monday, May 29, 2017 10:14 PM
> To: Anatol Belski <ab@php.net>
> Cc: Nikita Popov <nikita.ppv@gmail.com>; PHP Internals
> <internals@lists.php.net>
> Subject: Re: [PHP-DEV] [RFC][VOTE] Improved SSL / TLS constants
>
> Hey Anatol,
>
>
> Niklas, I'd have yet a question about the RFC - it only deals with stream
> wrappers, but there are indeed some other places at least in soap and mysqlnd.
> Don't you think, the RFC and implementation should recapitulate those?
>
Yep, here you are
https://github.com/php/php-src/blob/master/ext/soap/php_http.c#L305
https://github.com/php/php-src/blob/master/ext/mysqlnd/mysqlnd_net.c#L974
Basically it is the same story, as the old definitions are used, which the RFC aims to replace. It
might be consistent to have the behavior synced, or at least to evaluate it. And, there might yet
some places, not expecting much but just to be aware.
Regards
Anatol