Re: [RFC][VOTE] Improved SSL / TLS constants

2017-06-04 11:22 GMT+02:00 Niklas Keller <me@kelunik.com>: > 2017-05-29 22:29 GMT+02:00 Anatol Belski <ab@php.net>: > >> Hi Niklas, >> >> > -----Original Message----- >> > From: Niklas Keller [mailto:me@kelunik.com] >> > Sent: Monday, May 29, 2017 10:14 PM >> > To: Anatol Belski <ab@php.net> >> > Cc: Nikita Popov <nikita.ppv@gmail.com>; PHP Internals >> > <internals@lists.php.net> >> > Subject: Re: [PHP-DEV] [RFC][VOTE] Improved SSL / TLS constants >> > >> > Hey Anatol, >> > >> > >> > Niklas, I'd have yet a question about the RFC - it only deals >> with stream >> > wrappers, but there are indeed some other places at least in soap and >> mysqlnd. >> > Don't you think, the RFC and implementation should recapitulate those? >> > >> Yep, here you are >> >> >> https://github.com/php/php-src/blob/master/ext/soap/php_http.c#L305 >> >> https://github.com/php/php-src/blob/master/ext/mysqlnd/mysqlnd_net.c#L974 >> >> Basically it is the same story, as the old definitions are used, which >> the RFC aims to replace. It might be consistent to have the behavior >> synced, or at least to evaluate it. And, there might yet some places, not >> expecting much but just to be aware. >> >> Regards > > > Hi Anatol, > > I upgraded STREAM_CRYPTO_METHOD_TLS_CLIENT to be an alias > to STREAM_CRYPTO_METHOD_TLS_ANY_CLIENT now, so that automatically > upgrades any use of STREAM_CRYPTO_METHOD_TLS_CLIENT to use TLS 1.1 or TLS > 1.2 if available. > > Regards, Niklas > Hey everyone, thanks for voting! The voting has now been closed with 14 votes in favor and 0 against. You can see the full results on the voting page as always: https://wiki.php.net/rfc/improved-tls-constants#voting Regards, Niklas